perf: Field.toEuclideanDomain fast_instance%#39293
Open
kbuzzard wants to merge 2 commits into
Open
Conversation
Member
Author
|
!radar |
|
Benchmark results for 0d7dd61 against bcb9e00 are in. No significant results found. @kbuzzard
Small changes (6✅)
|
PR summary 4529a2df72
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Algebra.EuclideanDomain.Field | 184 | 185 | +1 (+0.54%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Algebra.EuclideanDomain.Field |
1 |
Declarations diff
+ instance (priority := 100) toEuclideanDomain : EuclideanDomain K := fast_instance%
- instance (priority := 100) toEuclideanDomain : EuclideanDomain K
You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.
No changes to strong technical debt.
No changes to weak technical debt.
Member
Author
|
Master now has #39263 so let's see if that makes a different (I suspect it will) !radar |
|
Benchmark results for 4529a2d against ec05634 are in. No significant results found. @kbuzzard
Small changes (1✅, 2🟥)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just an experiment. Pulled this fast_instance% off #38087 to see if it makes a difference. Will then try it after #39263 to see if it still makes a difference.